[Mesa-dev] [PATCH 10/11] etnaviv: implement resource creation with modifier

[Emil Velikov]

Hi Lucas,

On 23 June 2017 at 16:50, Lucas Stach <l.stach at pengutronix.de> wrote:

> +const uint64_t priority_to_modifier[] = {
I think you can make this static.

[snip]
>           res->texture =
> -            etna_resource_alloc(pctx->screen, ETNA_LAYOUT_TILED, &templat);
> +            etna_resource_alloc(pctx->screen, ETNA_LAYOUT_TILED, 0, &templat);

[snip]
> -      trans->rsc = etna_resource_alloc(pctx->screen, ETNA_LAYOUT_LINEAR, &templ);
> +      trans->rsc = etna_resource_alloc(pctx->screen, ETNA_LAYOUT_LINEAR, 0, &templ);

Worth using DRM_FORMAT_MOD_LINEAR instead of 0 in these cases as well?

-Emil