[Mesa-dev] [PATCH 01/14] mesa: remove redundant error check

Samuel Pitoiset samuel.pitoiset at gmail.com
Wed Jun 28 08:28:02 UTC 2017


Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 06/28/2017 08:13 AM, Timothy Arceri wrote:
> We do the same check in the shared code in the set_tex_parameterf()
> call.
> ---
>   src/mesa/main/texparam.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c
> index 3c110de..6c908af 100644
> --- a/src/mesa/main/texparam.c
> +++ b/src/mesa/main/texparam.c
> @@ -954,10 +954,6 @@ _mesa_texture_parameteriv(struct gl_context *ctx,
>      switch (pname) {
>      case GL_TEXTURE_BORDER_COLOR:
>         {
> -         if (!_mesa_target_allows_setting_sampler_parameters(texObj->Target)) {
> -            _mesa_error(ctx, GL_INVALID_ENUM, "glTextureParameteriv(texture)");
> -            return;
> -         }
>            /* convert int params to float */
>            GLfloat fparams[4];
>            fparams[0] = INT_TO_FLOAT(params[0]);
> 


More information about the mesa-dev mailing list