[Mesa-dev] [PATCH 0/2] vulkan/wsi/wayland: Improve surface format support

[Alexandros Frantzis]

On Tue, Jun 27, 2017 at 04:33:04PM -0700, Chad Versace wrote:
> On Fri 23 Jun 2017, alexandros.frantzis at collabora.com wrote:
> > From: Alexandros Frantzis <alexandros.frantzis at collabora.com>
> > 
> > Improve the surface format support in the Wayland Vulkan WSI, by
> > automating the matching between wl_drm and Vulkan formats. The same
> > mechanism can be used to improve format support in vulkan/wsi/x11
> > (in a future patchset).
> 
> Thanks for attacking this problem, and attempting to fix the format
> hacks in wsi_common_wayland.c.
> 
> I suspect that the two of us have significant differences in our
> interpretation of VkFormat bit-layouts. I've responded to patch 1/1 with
> a lot of comments and questions. Hopefully we can untangle our format
> interpretations and we reach a common understanding.

Hi Chad,

thanks for the review!

I have replied to your review of [PATCH 1/2] with a more detailed
explanation of my rationale and implementation choices, which will
hopefully help us reach a common understanding (and perhaps help to
clear any misconceptions I may have).

Thanks,
Alexandros

> 
> > 
> > Alexandros Frantzis (2):
> >   vulkan/util: Introduce format utilities
> >   vulkan/wsi/wayland: Use the format utilities to find compatible
> >     VkFormats
> > 
> >  src/vulkan/Makefile.sources         |   2 +
> >  src/vulkan/util/vk_format_util.c    | 173 +++++++++++++++++++++++++++++++++++
> >  src/vulkan/util/vk_format_util.h    | 100 ++++++++++++++++++++
> >  src/vulkan/wsi/wsi_common_wayland.c | 178 ++++++++++++++++++------------------
> >  4 files changed, 366 insertions(+), 87 deletions(-)
> >  create mode 100644 src/vulkan/util/vk_format_util.c
> >  create mode 100644 src/vulkan/util/vk_format_util.h
> > 
> > -- 
> > 2.11.0
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev