[Mesa-dev] [PATCH 3/4] st/dri: use image extension in drisw.c

[Emil Velikov]

On 9 June 2017 at 01:27, gurchetansingh at chromium.org
<gurchetansingh at chromium.org> wrote:
> From: Gurchetan Singh <gurchetansingh at chromium.org>
>
> This adds the image extension to the software GL implementation.
> ---
>  src/gallium/state_trackers/dri/drisw.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/gallium/state_trackers/dri/drisw.c b/src/gallium/state_trackers/dri/drisw.c
> index 8fbfa9ecea..45772532f3 100644
> --- a/src/gallium/state_trackers/dri/drisw.c
> +++ b/src/gallium/state_trackers/dri/drisw.c
> @@ -371,6 +371,7 @@ static const __DRIextension *drisw_screen_extensions[] = {
>     &dri2RendererQueryExtension.base,
>     &dri2ConfigQueryExtension.base,
>     &dri2FenceExtension.base,
> +   &dri2ImageExtension.base,
I would construct a local "sw" version of the extension which has only
the entry points that can work - as listed in 4/4.

>     NULL
>  };
>
> @@ -409,6 +410,8 @@ drisw_init_screen(__DRIscreen * sPriv)
>     if (!configs)
>        goto fail;
>
> +   dri2_init_image_extension(screen);
> +
This sets up the DMABuf callbacks, after calling an ioctl. This is a no-go.

Thanks
Emil