[Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

[Emil Velikov]

On 9 June 2017 at 01:28, gurchetansingh at chromium.org
<gurchetansingh at chromium.org> wrote:
> From: Gurchetan Singh <gurchetansingh at google.com>
>
> Otherwise, this extension is not visible to the EGL user
> ---
>  src/egl/drivers/dri2/egl_dri2.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
> index 7175e827c9..9e845e99e3 100644
> --- a/src/egl/drivers/dri2/egl_dri2.c
> +++ b/src/egl/drivers/dri2/egl_dri2.c
> @@ -429,6 +429,7 @@ static const struct dri2_extension_match swrast_driver_extensions[] = {
>
>  static const struct dri2_extension_match swrast_core_extensions[] = {
>     { __DRI_TEX_BUFFER, 2, offsetof(struct dri2_egl_display, tex_buffer) },
> +   { __DRI_IMAGE, 1, offsetof(struct dri2_egl_display, image) },
Considering the entry points used, check the exact _DRI_IMAGE version
needed (see dri_interface.h) and update accordingly.

Also move the line to optional_core_extensions, since by using
swrast_core_extensions you will fail to load older swrast_dri.so which
are otherwise perfectly capable of working (albeit w/o said EGL
extensions).

Before you ask - yes, extension is present in dri2_core_extensions, so
doing a second check is sub-optimal/strange.
Do add a comment clearing any ambiguities.

With that said - I'm back to addressing all the issues I've saw in libEGL ;-)

Thanks
Emil