[Mesa-dev] [PATCH 13/30] i965/miptree: Add an explicit format parameter to create_for_dri_image

Chad Versace chadversary at chromium.org
Wed Jun 28 16:53:08 UTC 2017


On Wed 28 Jun 2017, Daniel Stone wrote:
> Hi,
> 
> On 28 June 2017 at 02:05, Jason Ekstrand <jason at jlekstrand.net> wrote:

> > Would you feel more comfortable with a boolean sRGB parameter?  That would
> > make the answers to the above questions much more obvious at the cost of
> > some code.
> 
> s/boolean/enum/ and you're on. As said before, the number of booleans
> in this series already makes me sad, let alone adding more.

Yes, please. Pass an enum, and this code will become understandable.


More information about the mesa-dev mailing list