[Mesa-dev] [PATCH] Android: use symlinks for driver loading

[Rob Clark]

On Wed, Jun 28, 2017 at 12:51 PM, Rob Herring <robh at kernel.org> wrote:
> On Wed, Jun 28, 2017 at 11:46 AM, Eric Anholt <eric at anholt.net> wrote:
>> Rob Herring <robh at kernel.org> writes:
>>
>>> Instead of having special driver loading logic for Android, create
>>> symlinks to gallium_dri.so so we can use the standard loading logic.
>>>
>>> Signed-off-by: Rob Herring <robh at kernel.org>
>>
>>
>>> diff --git a/src/gallium/drivers/freedreno/Android.mk b/src/gallium/drivers/freedreno/Android.mk
>>> index 330e82420426..7b543097987c 100644
>>> --- a/src/gallium/drivers/freedreno/Android.mk
>>> +++ b/src/gallium/drivers/freedreno/Android.mk
>>> @@ -50,6 +50,7 @@ include $(GALLIUM_COMMON_MK)
>>>  include $(BUILD_STATIC_LIBRARY)
>>>
>>>  ifneq ($(HAVE_GALLIUM_FREEDRENO),)
>>> +GALLIUM_TARGET_DRIVERS += msm
>>>  $(eval GALLIUM_LIBS += $(LOCAL_MODULE) libmesa_winsys_freedreno)
>>>  $(eval GALLIUM_SHARED_LIBS += $(LOCAL_SHARED_LIBRARIES))
>>>  endif
>>
>> Looks like the automake build also gives this one a symlink under "kgsl"
>
> IIUC, that's for use with downstream components. We don't support that
> on Android already, and I see no reason that we need to.

using downstream kgsl kernel also probably doesn't work with any
kernel that supported a4xx or a5xx.. and when it worked, it was a
kernel old enough not to have dma-buf, dma-fence, etc.  So I tend to
agree that there is no need for kgsl symlink.

BR,
-R