[Mesa-dev] [PATCH 2/5] dri: Add a flushSwapBuffers method to the image loader extension

[Emil Velikov]

On 22 June 2017 at 11:42, Thomas Hellstrom <thellstrom at vmware.com> wrote:
> This method may be used by dri drivers to make sure all outstanding
> buffer swaps have been flushed to hardware. Also add a dri3 implementation.
>
Based on the description we'd want this for EGL as well, won't we?
At least in the EGL/X11 case.

> Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
> ---
>  include/GL/internal/dri_interface.h | 16 +++++++++++++++-
>  src/glx/dri3_glx.c                  | 29 +++++++++++++++++++++++++++++
Please keep these separate patches - interface, GLX implementation,
EGL(?) implementation.

> @@ -525,6 +553,7 @@ static const __DRIimageLoaderExtension imageLoaderExtension = {
>
>     .getBuffers          = loader_dri3_get_buffers,
>     .flushFrontBuffer    = dri3_flush_front_buffer,
> +   .flushSwapBuffers    = dri3_flush_swap_buffers,
Without bumping the version (just outside of the diff) I'm not sure
how you've tested the patch.
Looking at v4 (the user) it already requires both a version bump and a
non-NULL hook.

Thanks
Emil