[Mesa-dev] [PATCH v2 3/3] gallium/hud: Prevent buffer overflow in hud_thread_busy_install

Robert Foss robert.foss at collabora.com
Thu Jun 29 13:21:28 UTC 2017


Switch to using strncopy to avoid potential overflow of
name array in struct hud_graph.

Coverity-id: 1413760

Signed-off-by: Robert Foss <robert.foss at collabora.com>
---
Changes since v1:
  Gustaw Smolarczyk <wielkiegie at gmail.com>
  - Fix strcpy -> strncpy typo

 src/gallium/auxiliary/hud/hud_cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/auxiliary/hud/hud_cpu.c b/src/gallium/auxiliary/hud/hud_cpu.c
index 468c36207b..ceadccb377 100644
--- a/src/gallium/auxiliary/hud/hud_cpu.c
+++ b/src/gallium/auxiliary/hud/hud_cpu.c
@@ -288,7 +288,7 @@ hud_thread_busy_install(struct hud_pane *pane, const char *name, bool main)
    if (!gr)
       return;
 
-   strcpy(gr->name, name);
+   strcpy(gr->name, name, HUD_GRAPH_NAME_LEN);
 
    gr->query_data = CALLOC_STRUCT(thread_info);
    if (!gr->query_data) {
-- 
2.11.0



More information about the mesa-dev mailing list