[Mesa-dev] [PATCH 2/5] vc4: Switch back to using a local copy of vc4_drm.h.

[Emil Velikov]

On 29 June 2017 at 16:38, Eric Anholt <eric at anholt.net> wrote:
> Emil Velikov <emil.l.velikov at gmail.com> writes:
>
>> Hi Eric,
>>
>> On 29 June 2017 at 02:15, Eric Anholt <eric at anholt.net> wrote:
>>> Needing to get our uapi header from libdrm has only complicated things.
>>> Follow intel's lead and drop our requirement for it.
>>>
>> UAPI: I think I may have noticed some compat breakage here.
>>
>> The sizeof above struct will differ across 32/64bit builds and since
>> it's embedded below I doubt one can change it now.
>
> Why are you reviewing the existing UAPI in this patch?  It's UAPI.
Yes, UAPI cannot be broken/changed.

Guess I'm just naive enough, trying to help before corruption and/or
crashes occur.
If you've already sorted that - pardon for the noise. A simple - "It's
already addressed" would have been appreciated.

-Emil