[Mesa-dev] [PATCH 4/4] i965/miptree: Partially resolve MCS for texture views

[Ian Romanick]

On 06/26/2017 11:49 AM, Jason Ekstrand wrote:
> ---
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> index c94fb4f..829a4c5 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> @@ -2511,14 +2511,14 @@ intel_miptree_prepare_texture_slices(struct brw_context *brw,
>           aux_supported = clear_supported = true;

Should this be changed to

          aux_supported = true;

And if that's the case, then maybe the whole thing should be

      aux_supported = (mt->num_samples > 1) ||
                      can_texture_with_ccs(brw, mt, view_format);

>        } else {
>           aux_supported = can_texture_with_ccs(brw, mt, view_format);
> -
> -         /* Clear color is specified as ints or floats and the conversion is
> -          * done by the sampler.  If we have a texture view, we would have to
> -          * perform the clear color conversion manually.  Just disable clear
> -          * color.
> -          */
> -         clear_supported = aux_supported && (mt->format == view_format);
>        }
> +
> +      /* Clear color is specified as ints or floats and the conversion is
> +       * done by the sampler.  If we have a texture view, we would have to
> +       * perform the clear color conversion manually.  Just disable clear
> +       * color.
> +       */
> +      clear_supported = aux_supported && (mt->format == view_format);
>     } else if (mt->format == MESA_FORMAT_S_UINT8) {
>        aux_supported = clear_supported = false;
>     } else {
>