[Mesa-dev] [PATCH] mesa: Avoid set comprehension.

[Dylan Baker]

Gahh, we're seriously still supporting 2.6 for builds? 2.6 was EOL in 2013, and
2.7 was shiny and new in 2010. It's also going to make hybridizing for 3.x
incredibly painful. If possible I'd really like to not support 2.6, though I'm
sure that will cause pain for the RHEL guys...

Quoting Vinson Lee (2017-06-28 23:20:14)
> Fix build error on CentOS 6.9 with Python 2.6.
> 
>   GEN    main/format_fallback.c
>   File "./main/format_fallback.py", line 42
>     names = {fmt.name for fmt in formats}
>                         ^
> SyntaxError: invalid syntax
> 
> Fixes: a1983223d883 ("mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]")
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  src/mesa/main/format_fallback.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/mesa/main/format_fallback.py b/src/mesa/main/format_fallback.py
> index e3b9916..da88bd5 100644
> --- a/src/mesa/main/format_fallback.py
> +++ b/src/mesa/main/format_fallback.py
> @@ -39,7 +39,7 @@ def parse_args():
>      return p.parse_args()
>  
>  def get_rgbx_to_rgba_map(formats):
> -    names = {fmt.name for fmt in formats}
> +    names = set([fmt.name for fmt in formats])

Either way, this is the wrong way to implement this, this should be:

    names = set(fmt.name for fmt in formats)

Which avoids building an intermediate list, and then converting to a set.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170629/82615422/attachment-0001.sig>