[Mesa-dev] Why are we using server-side GLX fbconfigs?

[Thomas Hellstrom]

On 06/29/2017 07:30 PM, Kristian Høgsberg wrote:
> On Thu, Jun 29, 2017 at 7:36 AM, Thomas Hellstrom <thellstrom at vmware.com> wrote:
>> Hi!
>>
>> I was spending some time going through the GLX code to try to fix up the
>> GLX_OML_swap_method extension implementation.
>>
>> I then stumbled across the fact that when we, for direct rendering
>> connections, construct the list of fbconfigs, we start out with the server
>> provided fbconfigs from the AIGLX driver and then try to match each fbconfig
>> with a corresponding client driver driconfig. Effectively making us use the
>> intersection of the server AIGLX capabilities and the client Direct
>> rendering capabilities.
>>
>> Wouldn't it be more correct, or at least "better" if we, for direct
>> rendering, took a list of client driver driconfigs, matched each with a
>> server provided visual and if we have a match, built an fbconfig from that
>> driconfig? That would make us essentialy exposing all client driver
>> capabilities regardless of what the server is using, as long as we have a
>> matching visual?
>>
>> Any insights into this would be greatly appreciated.
> I'm largely to blame for that. Historically it was part me trying to
> keep things working they did before as well as having to pay more
> attention to server side configs as DRI2 tried to share aux buffers
> (not just color) between clients. I think mesa today only shares color
> buffers with DRI2 and DRI3 is obviously fine, so what you're proposing
> sounds like a nice simplification of the code as well as something
> that might expose more configs to the client.
>
> Kristian

OK. Thanks Kristian.

FWIW, from what I can tell, dri3 only shares the real front. Has dri2 
been modified to also allocate local buffers?

Thanks,
Thomas





>> Thanks,
>>
>> Thomas
>>
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=DwIBaQ&c=uilaK90D4TOVoH58JNXRgQ&r=wnSlgOCqfpNS4d02vP68_E9q2BNMCwfD2OZ_6dCFVQQ&m=ggEEtfO2kSccqTNeC7ze2E2-hHxAbEJifKAeknMDbyY&s=9vJcxYsmdV4CXmI7ENFECWzNxM_fQwf4ft83ZlKcWuo&e=