[Mesa-dev] [PATCH 2/2] gallium/docs: document that TXF is used with PIPE_BUFFER resources

[Roland Scheidegger]

Am 30.06.2017 um 17:25 schrieb Brian Paul:
> ---
>  src/gallium/docs/source/tgsi.rst | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst
> index fab0012..6214de3 100644
> --- a/src/gallium/docs/source/tgsi.rst
> +++ b/src/gallium/docs/source/tgsi.rst
> @@ -939,7 +939,8 @@ XXX doesn't look like most of the opcodes really belong here.
>  .. opcode:: TXF - Texel Fetch
>  
>    As per NV_gpu_shader4, extract a single texel from a specified texture
> -  image. The source sampler may not be a CUBE or SHADOW.  src 0 is a
> +  image or PIPE_BUFFER resource. The source sampler may not be a CUBE or
> +  SHADOW.  src 0 is a
>    four-component signed integer vector used to identify the single texel
>    accessed. 3 components + level.  Just like texture instructions, an optional
>    offset vector is provided, which is subject to various driver restrictions
> 

I think the wording here is still a bit confusing, because the texture
image is still referenced by the sampler number (even if there's no
actual sampler bound for it). Also, when I hear "texture image" I'd
never think this wouldn't include pipe_buffer resources (not when
talking about texel fetch, at least).
But I'm fine with the new wording.
Reviewed-by: Roland Scheidegger <sroland at vmware.com>