[Mesa-dev] [PATCH 1/2] gallium/docs: clarify that samplers are not used with PIPE_BUFFER resources

[Roland Scheidegger]

Am 30.06.2017 um 17:25 schrieb Brian Paul:
> Commit 8aba778fa2cd98a0b5a7429d3c5057778a0c808c "st/mesa: don't set
> sampler states for TBOs" changed how texture buffer objects are handled.
> Document the new convention.
> ---
>  src/gallium/docs/source/context.rst | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/src/gallium/docs/source/context.rst b/src/gallium/docs/source/context.rst
> index 6563a7e..a46131c 100644
> --- a/src/gallium/docs/source/context.rst
> +++ b/src/gallium/docs/source/context.rst
> @@ -99,6 +99,14 @@ objects. They all follow simple, one-method binding calls, e.g.
>    various debug messages, eventually reported via KHR_debug and
>    similar mechanisms.
>  
> +Samplers
> +^^^^^^^^
> +
> +pipe_sampler_state objects control how textures are sampled (coordinate
> +wrap modes, interpolation modes, etc).  Note that samplers are not used
> +for texture buffer objects.  That is, pipe_context::bind_sampler_views()
> +will not bind a sampler if the corresponding sampler view refers to a
> +PIPE_BUFFER resource.
>  
>  Sampler Views
>  ^^^^^^^^^^^^^
> 

Reviewed-by: Roland Scheidegger <sroland at vmware.com>
(Note that samplers aren't used for sample opcodes neither which don't
require them, in particular SAMPLE_I, regardless if the resource is a
texture or a buffer. But this should be obvious due to how these sample
opcodes work.)