[Mesa-dev] [PATCH 11/24] i965: Move SOL binding #defines to brw_compiler.h

Kenneth Graunke kenneth at whitecape.org
Wed Mar 1 09:18:06 UTC 2017


On Tuesday, February 28, 2017 9:03:23 PM PST Jason Ekstrand wrote:
> While we're at it, we also change the GEN6 binding macro to be a start
> index that gets added to the binding.  This makes things a bit more
> explicit.

Eh.  It's a stylistic choice, I guess.

The old macro,

    #define SURF_INDEX_GEN6_SOL_BINDING(t) (t)

would give the surface index for binding 't'.  It could have been
written as 0 + t, which would have been more explicit.  I didn't think
it was particularly unclear.

But the style you use here isn't bad either, so...*shrug*.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170301/06a34514/attachment.sig>


More information about the mesa-dev mailing list