[Mesa-dev] [Mesa-stable] [PATCH] i965: Select pipeline and emit state base address in Gen8+ HiZ ops.

[Emil Velikov]

On 6 February 2017 at 23:55, Kenneth Graunke <kenneth at whitecape.org> wrote:
> If a HiZ op is the first thing in the batch, we should make sure
> to select the render pipeline and emit state base address before
> proceeding.
>
> I believe 3DSTATE_WM_HZ_OP creates 3DPRIMITIVEs internally, and
> dispatching those on the GPGPU pipeline seems a bit sketchy.  I'm
> not actually sure that STATE_BASE_ADDRESS is necessary, as the
> depth related commands use graphics addresses, not ones relative
> to the base address...but we're likely to set it as part of the
> next operation anyway, so we should just do it right away.
>
> Cc: "17.0" <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/gen8_depth_state.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/gen8_depth_state.c b/src/mesa/drivers/dri/i965/gen8_depth_state.c
> index a7e61354fd5..620b32df8bb 100644
> --- a/src/mesa/drivers/dri/i965/gen8_depth_state.c
> +++ b/src/mesa/drivers/dri/i965/gen8_depth_state.c
> @@ -404,6 +404,9 @@ gen8_hiz_exec(struct brw_context *brw, struct intel_mipmap_tree *mt,
>     if (op == BLORP_HIZ_OP_NONE)
>        return;
>
> +   brw_select_pipeline(brw, BRW_RENDER_PIPELINE);
> +   brw_upload_state_base_address(brw);
> +

Doesn't seem like this patch has landed in master yet. Is it due to
shortage of review or it's been superseded ?

Thanks
Emil