[Mesa-dev] [PATCH 00/24] i965: Move the compiler to src/intel/compiler

[Matt Turner]

On Wed, Mar 1, 2017 at 9:00 AM, Jason Ekstrand <jason at jlekstrand.net> wrote:
> On Wed, Mar 1, 2017 at 8:40 AM, Matt Turner <mattst88 at gmail.com> wrote:
>>
>> On Tue, Feb 28, 2017 at 9:03 PM, Jason Ekstrand <jason at jlekstrand.net>
>> wrote:
>> > This little series moves the i965 back-end compiler to
>> > src/intel/compiler.
>> > It's not incredibly pretty; I didn't do as much header clean-up as
>> > perhaps
>> > could have been done.  Anything that I didn't know what to do with I
>> > moved
>> > to brw_shader or brw_program.  The second-to-last patch which shuffles
>> > the
>> > header includes around is also one big patch.  It could be split up but
>> > there didn't seem to be much of a point.
>> >
>> > Jason Ekstrand (24):
>> >   i965: Move a couple of #defines from brw_context to brw_compiler
>> >   i965: Move some helpers from brw_context.h to brw_shader.h
>> >   i965: Move brw_disassemble_inst to brw_eu.h
>> >   i965: Move some gen4 WM defines to brw_compiler.h
>> >   i965: Move assign_common_binding_table_offsets to brw_program
>> >   i965/vue_map: Stop using GLbitfield types
>>
>> I made it through these patches before I went to bed, so they are
>>
>> Reviewed-by: Matt Turner <mattst88 at gmail.com>
>>
>> >   i965: Get rid of BRW_PRIM_OFFSET
>> >   i965: Don't use MAX_SURFACES in mark_surface_used
>> >   i965/gs: Add the gl_prim_to_hw_prim table to vec4_gs_visitor.cpp
>> >   i964/gs: Move MAX_GS_INPUT_VERTICES to brw_vec4_gs_visitor.h
>> >   i965: Move SOL binding #defines to brw_compiler.h
>> >   i965: Move SHADER_TIME_STRIDE to brw_compiler.h
>> >   i965: Move brw_register_blocks to brw_fs.cpp
>> >   i965/inst: Stop using fi_type
>> >   i965: Move BRW_MAX_DRAW_BUFFERS to brw_compiler.h
>> >   i965: Move BRW_ATTRIB_WA_* defines to brw_compiler.h
>> >   i965: Make mark_surface_used a static inline in brw_compiler.h
>> >   i965: Move channel_expressions and vector_splitting to brw_program.h
>> >   i965: Move image uniform setup to brw_nir_uniforms.cpp
>> >   i965: Move a bunch of pre-compile and link stuff to brw_program.h
>> >   i965: Add a header for brw_vec4_vs_visitor
>> >   i965: Delete brw_do_cubemap_normalize
>>
>> I see Ken reviewed these at 1:42am, so I won't bother.
>>
>> >   i965: Reduce cross-pollination between the DRI driver and compiler
>> >   i965: Move the back-end compiler to src/intel/compiler
>>
>> Like I said on IRC, I'd rather hold this until IVB/fp64 has landed.
>> They've done enough irritating work to have to go through an
>> unnecessary rebase.
>
>
> Hold off on the move or the header shuffling?  I don't think the header
> shuffling will affect them.  I'm more than happy to hold off on the move.

Just the move. Sorry for the confusion.