[Mesa-dev] [PATCH 4/7] intel/isl: Stop linking libi965_compiler.la into tests

Emil Velikov emil.l.velikov at gmail.com
Thu Mar 2 13:07:11 UTC 2017


On 2 March 2017 at 12:24, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 2 March 2017 at 05:28, Jason Ekstrand <jason at jlekstrand.net> wrote:
>> ---
>>  src/intel/Makefile.isl.am | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/src/intel/Makefile.isl.am b/src/intel/Makefile.isl.am
>> index 5a317f5..ee2215d 100644
>> --- a/src/intel/Makefile.isl.am
>> +++ b/src/intel/Makefile.isl.am
>> @@ -74,7 +74,6 @@ TESTS += $(check_PROGRAMS)
>>  isl_tests_isl_surf_get_image_offset_test_LDADD = \
>>         common/libintel_common.la \
>>         isl/libisl.la \
>> -       $(top_builddir)/src/mesa/drivers/dri/i965/libi965_compiler.la \
>
> Did we get rid of the src/mesa/drivers/dri/i965 (and? src/mapi/
> src/mesa) -I with the i965 compiler move series ? If not we want to do
> it here.
>
> With that nitpick
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
>
Seems like you're handling all those in one go in patch 7/7. Feel free
to ignore my suggestion here.

-Emil


More information about the mesa-dev mailing list