[Mesa-dev] [PATCH 3/7] anv/tests: Use a relative include path for anv_private.h

Jason Ekstrand jason at jlekstrand.net
Thu Mar 2 20:13:10 UTC 2017


On Thu, Mar 2, 2017 at 4:19 AM, Emil Velikov <emil.l.velikov at gmail.com>
wrote:

> On 2 March 2017 at 05:28, Jason Ekstrand <jason at jlekstrand.net> wrote:
> > ---
> >  src/intel/vulkan/tests/block_pool_no_free.c        | 2 +-
> >  src/intel/vulkan/tests/state_pool.c                | 2 +-
> >  src/intel/vulkan/tests/state_pool_free_list_only.c | 2 +-
> >  src/intel/vulkan/tests/state_pool_no_free.c        | 2 +-
> >  4 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/src/intel/vulkan/tests/block_pool_no_free.c
> b/src/intel/vulkan/tests/block_pool_no_free.c
> > index 86d1a76..4050f19 100644
> > --- a/src/intel/vulkan/tests/block_pool_no_free.c
> > +++ b/src/intel/vulkan/tests/block_pool_no_free.c
> > @@ -23,7 +23,7 @@
> >
> >  #include <pthread.h>
> >
> > -#include "anv_private.h"
> > +#include "../anv_private.h"
> >
> I've tried to prune most of these from the tree. Please pass the
> corresponding -I to the compiler instead.
>

About that... I chose to go this route expressly to avoid having to add the
-I.  If I add the -I, I either make everything in src/intel have
-Isrc/intel/vulkan which seems rather silly, or I have to add a CPPFLAGS
parameter for every single test.  I could do the latter but it makes for
quite a bit of makefile bloat so I chose the former.  If you'd rather bloat
the makefile, we can do that.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170302/cc783b3c/attachment.html>


More information about the mesa-dev mailing list