[Mesa-dev] [PATCH v2 18/18] anv/image: Allow HiZ on input attachment-capable depth/stencil images

Nanley Chery nanleychery at gmail.com
Thu Mar 2 21:21:20 UTC 2017


On Thu, Mar 02, 2017 at 11:03:44AM -0800, Jason Ekstrand wrote:
> On Mar 2, 2017 10:57 AM, "Nanley Chery" <nanleychery at gmail.com> wrote:
> 
> On Wed, Mar 01, 2017 at 04:46:42PM -0800, Jason Ekstrand wrote:
> > I didn't re-read every patch, just the ones I made comments on.  Assuming
> > only the commented patches made real changes, the series is
> >
> > Reviewed-by: Jason Ekstrand <jason at jlekstrand>
> >
> > I really like the direction things are going.
> >
> 
> Thanks!
> 
> I had to update one patch due to rebasing conflicts that occurred today.
> Please see:
> [PATCH v3] anv/descriptor_set: Store aux usage of sampled image descriptors
> 
> 
> I might have split that into two patches with the refactoring separate from
> the aux usage change bit they're fine squashed together.
> 

That's a good point. I will try to keep that in mind next time.

> Also, updating the patch, "anv/image: Add anv_layout_to_aux_usage()",
> caused the patches that modify transition_depth_buffer() to change. The
> 
> 
> Yup.  I saw that.  Looks fine to me.
> 
> end result looks about the same to me. Does your Rb still apply?
> 
> 
> Yup.  Land it.
> 

With the fix discussed on IRC, this series has been pushed.


More information about the mesa-dev mailing list