[Mesa-dev] [PATCH] mesa: Use _mesa_has_OES_geometry_shader() when validating draws

[Tomasz Figa]

On Thu, Mar 2, 2017 at 5:41 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On Wednesday, March 1, 2017 6:09:30 PM PST Ilia Mirkin wrote:
>> So, I have a few conflicting thoughts:
>>
>> (a) I hate having to saddle the code with impossible conditions. This
>> change may seem minor but it's an admission that non-sensical context
>> settings are OK. I don't think the code should be made to handle every
>> conceivable scenario, only reasonable ones.
>
> I agree...it is pretty weird.
>
>> (b) Having extension bools being set depend on version numbers is not
>> great -- the version is determined by what extensions are enabled, so
>> if you're a driver like i965, you can have it all nicely controlled in
>> one place. If you're in the st_extensions.c logic bit for a gallium
>> driver, there's a bit of guesswork regarding which version will
>> ultimately be exposed. The half-assed solution I came up with was to
>> largely copy the version.c logic over to determine when to set stuff.
>> So ... not great.
>>
>> Given that I'm conflicted on this in the first place, and the change
>> is quite minor, I yield to the people that have to make conformance
>> suites pass as part of their day job :)
>
> Alright.  I pushed the patch.  It's relatively minor, and as Tomasz
> pointed out, there's some inconsistency with regard to this already.
> We may as well take the patch since it helps ChromeOS folks now, and
> maybe we can improve things in the future...

Thanks!

Best regards,
Tomasz