[Mesa-dev] [RFC PATCH 0/7] gallium: Video postprocessor rework

[Christian König]

Hi Thomas,

Am 02.03.2017 um 21:00 schrieb Thomas Hellstrom:
> This patch series introduces a postprocessor abstraction. It could be promoted
> to a gallium interface but for now it's implemented as a utility.

Well, first of all use a gallium interface for this. Putting this into 
utility doesn't look like it makes much sense when it is supposed to be 
a driver interface.

> The idea
> is that a driver wanting to implement the whole or part of the postprocessing
> pipeline using video hardware can do that. It also significantly simplifies
> implementing a future full postprocessor pipeline also in the libVA
> state tracker.
>
> Some highlights:
> - The postprocessor abstraction is very similar to the vl compositor API,
> except it add filters.

NAK on that, we already had that design and it was a pain to support.

If you want to implement parts of the post processing pipeline in the 
driver make each pipeline step a separate object.

> - The bounce buffer cache. Caches buffers where we know more about the usage.
> This may duplicate driver functionality but for drivers with strongly typed
> buffers, it's a big win.

That's similar to what I've done for the video buffers, but in general I 
think that this doesn't belong into the state tracker.

The driver should implement buffer reuse if it can do this without 
problems, but how many buffers should be in there and when they are 
reclaimed is strongly hardware dependent.

> - Moving the bicubic filter. Avoids duplicated code and makes things like
> rotation and blending straightforward.

A BIG NAK on that as well. The bicubic filter doesn't work on all 
hardware, so creating the shaders all the time while it isn't use is 
clearly not an option.

Additional to that I would rather remove functionality from the 
compositor than stuffing even more into it.

> - A g3dvl implementation. Mostly replicates the old implementation using the
> vl compositor, but with provisions to replace part of the postprocessing
> pipeline.
> - State tracker modifications for VDPAU and VA.
>
> - Tested with mplayer -vo vdpau software playback on Nouveau.

Please test that with radeon hardware as well if possible. Nouveau 
doesn't fully support all the functionality and project like Kodi don't 
test with it.

Regards,
Christian.

>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev