[Mesa-dev] [PATCH v3] i965: Add script to gen code for OA counter queries

[Emil Velikov]

On 2 March 2017 at 21:25, Robert Bragg <robert at sixbynine.org> wrote:
>
>
> On Mar 2, 2017 7:32 PM, "Emil Velikov" <emil.l.velikov at gmail.com> wrote:
>
> On 2 March 2017 at 18:58, Robert Bragg <robert at sixbynine.org> wrote:
>> Adds R/b from Dylan and Makefile fixups from Emil, including fixing race
>> with
>> parallel make builds (thanks). Just holding fast on the use of #pragma
>> once
>> though :-)
>>
> I think you want the "required=True" for all the fields, but feel free
> to do at a later stage.
>
>
> The header and code args are checked like:
>
>> if args.header:
>>        header_file = open(args.header, 'w')
>>
>> if args.code:
>>        c_file = open(args.code, 'w')
>
Mostly food for thought, feel free to _not_ reply.

- why would we want to generate only the header and not the source
file or vise-versa?
- we can call the generator with no output files - i.e. both --header
and --code can be empty, right ?
- what is going to happen if we do not pass the xml filename as an arg ?

-Emil