[Mesa-dev] [PATCH 1/4] configure.ac: increase required swr llvm to 3.9.0

[Emil Velikov]

On 3 March 2017 at 20:34, Rowley, Timothy O <timothy.o.rowley at intel.com> wrote:
>
>> On Mar 3, 2017, at 5:55 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>
>> On 3 March 2017 at 01:16, Tim Rowley <timothy.o.rowley at intel.com> wrote:
>>> GS implementation uses the masked.{gather,store} intrinsics,
>>> introduced in llvm-3.9.0.
>>
>> Please mention in the commit message that the SCons build already
>> requires 3.9 or later.
>> Can you add a note about the LLVM requirement and GS support in
>> docs/relnotes/17.1.0.html, with a separate commit on top ?
>
> Both of these are in v2 of the patch set.
>
Amazing, tyvm.

>> With this we have some ~20 preprocessor conditionals which want to be
>> cleaned up. Look for
>> $ git grep  "LLVM_.*VERSION\|HAVE_LLVM" -- src/gallium/drivers/swr/
>
> Ah, good catch.  We’ve been ratcheting up our required llvm version without cleaning out some of the cruft.  Internally we’re still using 3.8 so not all of these can be removed.  I’ll work on that in a follow-up patch, as it’s unrelated to the geometry shader implementation.
>
Skimming through the 3.9 specifics - they only handle removed
intrinsics - pmovsxbd/pmovsxwd/pmax/pmin. Thinking that new code
should be safe with 3.8 so one could just use it everywhere ?
And yes, separate cleanup patches is perfectly fine.

Thanks again,
Emil