[Mesa-dev] [PATCH] loader: Move non-error message to debug level

[Emil Velikov]

On 4 March 2017 at 22:07, Fabio Estevam <festevam at gmail.com> wrote:
> Currently when running mesa on imx6 the following loader warnings
> are seen:
>
> # kmscube -D /dev/dri/card1
> MESA-LOADER: device is not located on the PCI bus
> MESA-LOADER: device is not located on the PCI bus
> MESA-LOADER: device is not located on the PCI bus
> Using display 0x1920948 with EGL version 1.4
>
> As this is not an error message, change it to debug level in
> order to have a cleaner log output.
>
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> ---
>  src/loader/loader.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/loader/loader.c b/src/loader/loader.c
> index 3b28a0e..9b4752d 100644
> --- a/src/loader/loader.c
> +++ b/src/loader/loader.c
> @@ -282,7 +282,7 @@ drm_get_pci_id_for_fd(int fd, int *vendor_id, int *chip_id)
>           ret = 1;
>        }
>        else {
> -         log_(_LOADER_WARNING, "MESA-LOADER: device is not located on the PCI bus\n");
> +         log_(_LOADER_DEBUG, "MESA-LOADER: device is not located on the PCI bus\n");
Right, too much copy/pasta, thanks.
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Barring any objections, I'll push it in a couple of days.

Hmm we really want some of the others to become FATAL. Then again
things are still quite icky in there, so I'd bother as we get to
removing moar code ;-)

-Emil