[Mesa-dev] [PATCH 5/5] gallium/util: replace pipe_condvar_broadcast() with cnd_broadcast()

[Timothy Arceri]

On 05/03/17 11:30, Emil Velikov wrote:
> On 4 March 2017 at 23:41, Timothy Arceri <tarceri at itsqueeze.com> wrote:
>> pipe_condvar_broadcast() was made unnecessary with fd33a6bcd7f12.
> Fwiw I have some patches that do a similar cleanups on the thrd_*
> side. Need to test them one of these days - since they're not as
> trivial of a sed job.
>
>> ---
>>  src/gallium/auxiliary/os/os_thread.h              | 5 +----
>>  src/gallium/auxiliary/pipebuffer/pb_bufmgr_slab.c | 2 +-
>>  src/gallium/auxiliary/util/u_queue.c              | 4 ++--
>>  src/gallium/drivers/llvmpipe/lp_fence.c           | 2 +-
>>  src/gallium/drivers/rbug/rbug_core.c              | 6 +++---
>>  5 files changed, 8 insertions(+), 11 deletions(-)
>>
>> diff --git a/src/gallium/auxiliary/os/os_thread.h b/src/gallium/auxiliary/os/os_thread.h
>> index a8b5d92..6eca2ca 100644
>> --- a/src/gallium/auxiliary/os/os_thread.h
>> +++ b/src/gallium/auxiliary/os/os_thread.h
>> @@ -141,23 +141,20 @@ __pipe_mutex_assert_locked(pipe_mutex *mutex)
>>     assert(ret == thrd_busy);
>>     if (ret == thrd_success)
>>        mtx_unlock(mutex);
>>  #endif
>>  }
>>
>>  /* pipe_condvar
>>   */
>>  typedef cnd_t pipe_condvar;
>>
> I think we should we drop this typedef one as well.

Yeah I noticed that after sending. Will do a follow up.

> We could also
> follow-up with pipe_tsd_* front ?

My main aim is at this stage is to make u_queue generic enough to move 
it to src/util.

> In either case, it might be worth checking with Jose/others to update
> things on their end.
>
> For the series:
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

Thanks!

>
> -Emil
>