[Mesa-dev] [PATCH 6/6] configure.ac: Ensure libomxil-bellagio exists before invoking pkg-config.

[Matt Turner]

On Mon, Mar 6, 2017 at 4:57 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 6 March 2017 at 19:06, Matt Turner <mattst88 at gmail.com> wrote:
>> I was already tired of seeing the message
>>
>>     Package libomxil-bellagio was not found in the pkg-config search path.
>>     Perhaps you should add the directory containing `libomxil-bellagio.pc'
>>     to the PKG_CONFIG_PATH environment variable
>>     No package 'libomxil-bellagio' found
>>
>> on every configure, but I just got a distro bug reported where the user
>> was confused by this message and thought it indicated a bug.
>> ---
>>  configure.ac | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index d483baa..8d78aa6 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -2195,7 +2195,8 @@ AC_ARG_WITH([omx-libdir],
>>      [AS_HELP_STRING([--with-omx-libdir=DIR],
>>          [directory for the OMX libraries])],
>>      [OMX_LIB_INSTALL_DIR="$withval"],
>> -    [OMX_LIB_INSTALL_DIR=`$PKG_CONFIG --define-variable=libdir=\$libdir --variable=pluginsdir libomxil-bellagio`])
>> +    [OMX_LIB_INSTALL_DIR=`$PKG_CONFIG --define-variable=libdir=\$libdir --exists libomxil-bellagio && \
> We don't need the --define-variable in the above case, do we ? With
> that fixed

I reread the pkg-config man page, and I think you're right that it's not needed:

       --define-variable=VARIABLENAME=VARIABLEVALUE
              This sets a global value for a variable, overriding the
value in any .pc files. Most packages define the variable "prefix",
for  example,  so  you
              can say:
                $ pkg-config --print-errors --define-variable=prefix=/foo \
                             --variable=prefix glib-2.0

I was thinking it might determine where pkg-config looked for the pc
file, but it seems that it's used to override a variable specified in
the pc file.