[Mesa-dev] [PATCH 3/6] configure.ac: Use PKG_CHECK_VAR for wayland-scanner.

[Frank Binns]

Hi,

On 06/03/17 19:06, Matt Turner wrote:
> Available since pkg-config-0.28 and pkgconf-0.8.10.
>
> The removal of the AC_PATH_PROG is intentional. Use pkg-config.

It doesn't seem possible to cross-compile Mesa out of the box due
to it using the 'host' scanner (found via pkgconfig) instead of the
'build' scanner. It seems to me that it should actually try finding
the scanner via PATH before falling back to pkgconfig. This is what
Weston does, for example.

Anyway, this doesn't make anything worse in that regard (afaics) so:
Reviewed-by: Frank Binns <frank.binns at imgtec.com>

Thanks
Frank

> ---
>   configure.ac | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index de54f38..37f6b60 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2102,12 +2102,7 @@ if test "x$with_egl_platforms" != "x" -a "x$enable_egl" != xyes; then
>       AC_MSG_ERROR([cannot build egl state tracker without EGL library])
>   fi
>   
> -PKG_CHECK_MODULES([WAYLAND_SCANNER], [wayland-scanner],
> -        WAYLAND_SCANNER=`$PKG_CONFIG --variable=wayland_scanner wayland-scanner`,
> -        WAYLAND_SCANNER='')
> -if test "x$WAYLAND_SCANNER" = x; then
> -    AC_PATH_PROG([WAYLAND_SCANNER], [wayland-scanner])
> -fi
> +PKG_CHECK_VAR([WAYLAND_SCANNER], [wayland-scanner], [wayland_scanner])
>   
>   # Do per-EGL platform setups and checks
>   egl_platforms=`IFS=', '; echo $with_egl_platforms`