[Mesa-dev] [PATCH] glx: allow 0 for glXSwapIntervalSGI

[Ian Romanick]

On 03/07/2017 05:09 PM, Grazvydas Ignotas wrote:
> Makes vsync option work in The Talos Principle.

NAK.  The GLX_SGI_swap_control spec says:

    glXSwapIntervalSGI returns GLX_BAD_VALUE if parameter <interval> is
    less than or equal to zero.

They should use glXSwapIntervalMESA instead.  This is one of the reasons
we made the GLX_MESA_swap_control extension.

> Signed-off-by: Grazvydas Ignotas <notasas at gmail.com>
> ---
> no commit access
> perhaps this is stable worthy?
> 
>  src/glx/glxcmds.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c
> index 53c9f9c..7be4e73 100644
> --- a/src/glx/glxcmds.c
> +++ b/src/glx/glxcmds.c
> @@ -1750,7 +1750,7 @@ __glXSwapIntervalSGI(int interval)
>        return GLX_BAD_CONTEXT;
>     }
>  
> -   if (interval <= 0) {
> +   if (interval < 0) {
>        return GLX_BAD_VALUE;
>     }
>