[Mesa-dev] [PATCH 14/17] intel/compiler: automake: rename test_eu_compact and link against gtest
Emil Velikov
emil.l.velikov at gmail.com
Wed Mar 8 17:57:04 UTC 2017
On 8 March 2017 at 17:41, Jason Ekstrand <jason at jlekstrand.net> wrote:
> The commit message doesn't really make sense. It looks to me a lot more
> like we're doing a makefile unification and renaming test_eu_compact is a
> side-effect.
>
Agreed - it is a bit confusing. How about
"intel/compiler: link all tests again gtest, even test_eu_compact"
At the moment all the tests but test_eu_compact are actual C++ gtests.
To simplify things, we can move the gtest.la to the common TEST_LIBS.
As we're here, we can rename change the test extension [to .cpp] to
avoid using the confusing dummy.cpp.
Add a nice comment in the makefile for posterity."
If you prefer we can keep the git mv foo.c foo.cpp as separate commit
- I'm fine either way.
-Emil
More information about the mesa-dev
mailing list