[Mesa-dev] [PATCH 12/17] i965: Move the back-end compiler to src/intel/compiler

Emil Velikov emil.l.velikov at gmail.com
Wed Mar 8 18:02:38 UTC 2017


On 8 March 2017 at 17:37, Jason Ekstrand <jason at jlekstrand.net> wrote:
> On Wed, Mar 8, 2017 at 9:16 AM, Emil Velikov <emil.l.velikov at gmail.com>
> wrote:
>>
>> From: Jason Ekstrand <jason.ekstrand at intel.com>
>>
>> Mostly a dummy git mv with a couple of noticable parts:
>>  - With the earlier header cleanups, nothing in src/intel depends on
>> files in src/mesa/drivers/dri/i965/ - drop the -I...i965
>>  - Both Autoconf and Android builds are addressed. Thanks to Mauro and
>> Tapani for the help with the latter
>>  - brw_util.[ch] is not really compiler specific, so it's moved to i965.
>>  - update all src/intel/ targets to use the correct includes.
>>
>> [Emil Velikov: commit message, various small fixes througout]
>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>> ---
>>  src/intel/Android.blorp.mk                         |   2 +-
>>  .../Android.gen.mk => intel/Android.compiler.mk}   |  41 ++++++--
>>  src/intel/Android.isl.mk                           |   6 +-
>>  src/intel/Android.mk                               |   1 +
>>  src/intel/Makefile.am                              |   7 +-
>>  src/intel/Makefile.compiler.am                     | 116
>> +++++++++++++++++++++
>>  src/intel/Makefile.sources                         |  89 ++++++++++++++++
>>  src/intel/blorp/blorp_priv.h                       |   2 +-
>>  src/intel/compiler/.gitignore                      |  10 ++
>>  .../dri/i965 => intel/compiler}/brw_cfg.cpp        |   0
>>  .../drivers/dri/i965 => intel/compiler}/brw_cfg.h  |   0
>>  .../dri/i965 => intel/compiler}/brw_compiler.c     |   0
>>  .../dri/i965 => intel/compiler}/brw_compiler.h     |   0
>>  .../compiler}/brw_dead_control_flow.cpp            |   0
>>  .../compiler}/brw_dead_control_flow.h              |   0
>>  .../dri/i965 => intel/compiler}/brw_defines.h      |   0
>
>
> ugh...  I don't really want to put brw_defines.h in the compiler...  Half of
> brw_defines.h is really i965 GL stuff and half of it is compiler stuff.  I
> think what we really want to do is split brw_defines.h into brw_defines.h
> and brw_eu_defines.h and hope there isn't much overlap.
>
Agreed. Splitting it up would be better option. Would you guys give it
a try or shall I ?

-Emil


More information about the mesa-dev mailing list