[Mesa-dev] [RESEND v4 00/16] cleanup anv_entrpoints_gen.py

Emil Velikov emil.l.velikov at gmail.com
Wed Mar 8 18:11:34 UTC 2017


On 7 March 2017 at 21:14, Dylan Baker <dylan at pnwbakers.com> wrote:
> There are a number of small style cleanups and simplifications in this series,
> but the main changes are:
>  - use a mako template to generate the header and code rather than prints
>  - be python 3.x ready (the goal isn't to write python 3 code, but to write code
>    that is easy to port or hybridize)
>  - generate the header and the code in one go
>
> I've put emphasis on the readability of the template rather than the readability
> of the output code, it's relatively easy to pipe the code through 'indent' to
> make it more readable.
>
> This is available at my github:
> https://github.com/dcbaker/temp submit/anv_entrypoints-cleanup
>
> Notable changes in Version 2:
> - Pass XML file via an argument
> - add flag to control output directory
> - Attempt to update android makefiles
>
> Notable changes in Version 3:
> - Fix "do not edit" message to have proper file name
> - More Android.mk changes
> - Don't write both files at the same time
> - Provide the file name to be written to as an argument
>
> Notable changes in Version 4:
> - Do write both files at the same time, in a separate patch
> - Hopefully fix the build systems for real
>
Seems to work on my end. Since I'm not a python expert I'll only got for
Tested-by: Emil Velikov <emil.velikov at collabora.com>

Note that this will clash with the compile move series and I've
perfectly fine with fixing either one - depending on which lands
first.

-Emil


More information about the mesa-dev mailing list