[Mesa-dev] [PATCH 04/37] glsl/tests: suffix .sh/.py files as applicable

Eric Engestrom eric.engestrom at imgtec.com
Wed Mar 8 18:13:52 UTC 2017


On Wednesday, 2017-03-08 16:55:12 +0000, Emil Velikov wrote:
> On 6 March 2017 at 18:21, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> > On 23 February 2017 at 17:13, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> >> From: Emil Velikov <emil.velikov at collabora.com>
> >>
> >> This makes it easier/clearer as to:
> >>  - if the file should have the execute bit set (.py should not)
> >>  - do we need the shebang in the first place and if so what it should be
> >>
> >> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> >> ---
> >> This is going to clash with my earlier fixes in the area.
> > This patches fix one case but break another. I have more elaborate
> > fixes in progress, but in the meanwhile,
> >
> > Humble ping on the remaining patches - pretty much all of them remove
> > python shebang which we don't need in the first place ;-)
> >
> Final call - barring any objections I like to get these in later on today.
> 
> -Emil

On the python shebang issue, I usually like to keep the information of
which version is supported in the script itself instead of pushing the
responsibility to the callers, but it seems like this wasn't really done
here, so no objection on removing them.

Series is::
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

Cheers,
  Eric


More information about the mesa-dev mailing list