[Mesa-dev] [PATCH 3/5] anv/image: Fix return type of make_surface()

[Chad Versace]

On Mon 06 Mar 2017, Jason Ekstrand wrote:
> With modifiers, aren't we going to want to be able to reject an image if
> the provide bogus stuff?

The current Vulkan spec says that vkCreateImage() only fails due to
K_ERROR_OUT_OF_HOST_MEMORY and VK_ERROR_OUT_OF_DEVICE_MEMORY. It never
fails due to invalid input. The user is required to provide input that
satisifes a previous query to
vkGetPhysicalDeviceImageFormatProperties().

Originally, I wanted to preserve that behavior. If the user gives us
garbage, then they get garbage back.

But, after thinking about your comment, and Antoine's security concerns,
I recall that Antoine requested that we validate on import.

So... I need to think a little more about how we should validate on
import. About what's possible to validate and what's not.