[Mesa-dev] [PATCH 5/5] anv: Handle failure in make_hiz_surface_maybe()

[Chad Versace]

On Mon 06 Mar 2017, Jason Ekstrand wrote:
> On Mon, Mar 6, 2017 at 10:18 AM, Chad Versace <chadversary at chromium.org>
> wrote:
> 
> > make_ccs_surface_maybe() correctly handles failure
> > isl_surf_get_ccs_surf(). When it fails, the resultant VkImage is still
> > valid, just without a ccs surface.
> >
> > Same of make_mcs_surface_maybe() and isl_surf_get_mcs_surf().
> >
> > Fix make_hiz_surface_maybe() to do the same.
> >
> 
> except that isl_surf_get_hiz_surf, as currently called, should *never*
> fail.  When we do gen7 HiZ, we may want to handle failure though...  In any
> case, we probably at least want a perf warning if HiZ surface creation
> fails given that we expect it not to.

Ok. Then I'll drop this patch.

I wasn't aware that isl_surf_get_hiz_surf(), as used here, shouldn't
fail.