[Mesa-dev] [PATCH 0/8] nir: Require numbers of components to always match

[Jason Ekstrand]

On Wed, Mar 8, 2017 at 4:56 PM, Eric Anholt <eric at anholt.net> wrote:

> Jason Ekstrand <jason at jlekstrand.net> writes:
>
> > When NIR was first created, we were a bit lazy about numbers of
> components.
> > The rule was that a source couldn't consume more components than the
> thing
> > it was reading from.  However, this leads to a lot of confusion because
> you
> > now have a thing sourcing from a vec4 but only reading two of the
> > components.
> >
> > The solution to this is to disallow that case and require that the number
> > of components always match.  The one exception is ALU instructions
> because
> > they're designed to naturally swizzle things around like mad.  We already
> > require this restriction for phi instructions.  This series adds it for
> > intrinsics, texture instructions, and deref indirects.
> >
> > Cc: Kenneth Graunke <kenneth at whitecape.org>
> > Cc: Connor Abbott <cwabbott0 at gmaial.com>
>
> Other than the comments I gave, and needing to land the lowering patch,
> this series is:
>
> Reviewed-by: Eric Anholt <eric at anholt.net>
>

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170308/fe7c0864/attachment.html>