[Mesa-dev] [PATCH v2 1/1] clover: use pipe_resource references

[Vedran Miletić]

On 03/09/2017 12:21 AM, Jan Vesely wrote:
> v2: buffers are created with one reference.
> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> ---
> Vedran, can you confirm that this one still fixes the problem? Seems OK on EG.
> 

Unfortunately it does not, valgrind reports Invalid read here.

Regards,
Vedran

> Jan
> 
>  src/gallium/state_trackers/clover/core/resource.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/gallium/state_trackers/clover/core/resource.cpp b/src/gallium/state_trackers/clover/core/resource.cpp
> index 06fd3f6..aaf5d49 100644
> --- a/src/gallium/state_trackers/clover/core/resource.cpp
> +++ b/src/gallium/state_trackers/clover/core/resource.cpp
> @@ -25,6 +25,7 @@
>  #include "pipe/p_screen.h"
>  #include "util/u_sampler.h"
>  #include "util/u_format.h"
> +#include "util/u_inlines.h"
>  
>  using namespace clover;
>  
> @@ -176,7 +177,7 @@ root_resource::root_resource(clover::device &dev, memory_obj &obj,
>  }
>  
>  root_resource::~root_resource() {
> -   device().pipe->resource_destroy(device().pipe, pipe);
> +   pipe_resource_reference(&this->pipe, NULL);
>  }
>  
>  sub_resource::sub_resource(resource &r, const vector &offset) :
> 

-- 
Vedran Miletić
vedran.miletic.net