[Mesa-dev] [PATCH] glsl: remove unused file

Emil Velikov emil.l.velikov at gmail.com
Thu Mar 9 16:00:05 UTC 2017


Hi Elie,

On 9 March 2017 at 15:16, Elie Tournier <tournier.elie at gmail.com> wrote:
> udivmod64 appears in src/compiler/glsl/builtin_int64.h and src/compiler/glsl/udivmod.h
> The second file seems unused.
> Fix commit 6b03b345eb64e15e577bc8b2cf04b314a4c70537
>
> This change doesn't affect shader-db.
>
Thanks for double-checking.

Just a couple of nitpicks:
s/remove unused file/remove unused file udivmod64.h/
s/udivmod.h/udivmod64.h/

Please use the canonical:
Fixes: 6b03b345eb6 ("glsl: Add "built-in" function for 64-bit integer sign()")

With the above:
Suggested-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil


More information about the mesa-dev mailing list