[Mesa-dev] [Mesa-stable] [PATCH] glapi: fix typo in count_scale

[Marek Olšák]

On Thu, Mar 9, 2017 at 10:20 PM, Timothy Arceri <tarceri at itsqueeze.com> wrote:
>
>
> On 09/03/17 02:38, Emil Velikov wrote:
>>
>> On 6 March 2017 at 04:25, Timothy Arceri <tarceri at itsqueeze.com> wrote:
>>>
>>> From: Gregory Hainaut <gregory.hainaut at gmail.com>
>>>
>>>  2*4=8
>>>
>>> Signed-off-by: Gregory Hainaut <gregory.hainaut at gmail.com>
>>> Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
>>> ---
>>>  src/mapi/glapi/gen/gl_API.xml | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/mapi/glapi/gen/gl_API.xml
>>> b/src/mapi/glapi/gen/gl_API.xml
>>> index f81ad1d..c94cccc 100644
>>> --- a/src/mapi/glapi/gen/gl_API.xml
>>> +++ b/src/mapi/glapi/gen/gl_API.xml
>>> @@ -5869,21 +5869,21 @@
>>>          <param name="location" type="GLint"/>
>>>          <param name="count" type="GLsizei" counter="true"/>
>>>          <param name="transpose" type="GLboolean"/>
>>>          <param name="value" type="const GLfloat *" count="count"
>>> count_scale="6"/>
>>>          <glx ignore="true"/>
>>>      </function>
>>>      <function name="UniformMatrix2x4fv" es2="3.0">
>>>          <param name="location" type="GLint"/>
>>>          <param name="count" type="GLsizei" counter="true"/>
>>>          <param name="transpose" type="GLboolean"/>
>>> -        <param name="value" type="const GLfloat *" count="count"
>>> count_scale="6"/>
>>> +        <param name="value" type="const GLfloat *" count="count"
>>> count_scale="8"/>
>>
>>
>> Fairly sure we want this in stable... feel free to shout otherwise.
>
>
> It wont hurt but I think this was introduced for gl thread so I think it's
> unused otherwise. Or I'm I wrong about that?

I've forgotten most things about glthread, need to re-read the code.
Your answer lies in the glthread branch. ;)

Marek