[Mesa-dev] [PATCH 1/2] nir/constant_expressions: Refactor helper functions

Dylan Baker dylan at pnwbakers.com
Thu Mar 9 23:01:28 UTC 2017


Quoting Jason Ekstrand (2017-03-09 14:19:33)
> On Thu, Mar 9, 2017 at 12:25 PM, Dylan Baker <dylan at pnwbakers.com> wrote:
> 
> 
> 
>     Quoting Jason Ekstrand (2017-03-09 10:23:56)
>     > +def op_bit_sizes(op):
>     > +    sizes = set([8, 16, 32, 64])
>     > +    if not type_has_size(op.output_type):
>     > +        sizes = sizes.intersection(set(type_sizes(op.output_type)))
>     > +    for input_type in op.input_types:
>     > +      if not type_has_size(input_type):
> 
>     The indent looks off here, mixed tabs?
> 
> 
> No, it's 4 tabs vs. 3 that's causing problems.  Fixed locally.

Thanks!

>  
> 
>     with that fixed:
>     Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170309/9f03108d/attachment.sig>


More information about the mesa-dev mailing list