[Mesa-dev] [PATCH 1/2] intel: genxml: add script to generate gzipped genxml

Emil Velikov emil.l.velikov at gmail.com
Fri Mar 10 18:01:13 UTC 2017


Hi Lionel,

I thinking about this just the other day - we have zlib dependency,
yet we store some ~1MiB of XML in the binary.
Not to mention that some distros ship xxd as part of vim ... but that
a distro problem ;-)

On 10 March 2017 at 16:26, Lionel Landwerlin
<lionel.g.landwerlin at intel.com> wrote:
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
>  src/intel/Makefile.genxml.am        |  1 +
>  src/intel/genxml/gen_zipped_file.py | 25 +++++++++++++++++++++++++
>  2 files changed, 26 insertions(+)
>  create mode 100755 src/intel/genxml/gen_zipped_file.py
>
> diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.genxml.am
> index 20e4b15786..1866d7e2df 100644
> --- a/src/intel/Makefile.genxml.am
> +++ b/src/intel/Makefile.genxml.am
> @@ -60,4 +60,5 @@ EXTRA_DIST += \
>         genxml/genX_pack.h \
>         genxml/gen_macros.h \
>         genxml/gen_pack_header.py \
> +       genxml/gen_zipped_file.py \
>         genxml/README
> diff --git a/src/intel/genxml/gen_zipped_file.py b/src/intel/genxml/gen_zipped_file.py
> new file mode 100755
> index 0000000000..d5735336c5
> --- /dev/null
> +++ b/src/intel/genxml/gen_zipped_file.py
> @@ -0,0 +1,25 @@
> +#!/usr/bin/env python2
Please drop this line alongside the file execute bit. We explicitly
open these via $PYTHON2

-Emil


More information about the mesa-dev mailing list