[Mesa-dev] [PATCH v2 1/2] intel: genxml: add script to generate gzipped genxml

[Dylan Baker]

Quoting Lionel Landwerlin (2017-03-10 10:00:12)
> v2 (from Dylan):
>    Add main function
>    Add missing Copyright
>    Use print_function
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
>  src/intel/Makefile.genxml.am        |  1 +
>  src/intel/genxml/gen_zipped_file.py | 29 +++++++++++++++++++++++++++++
>  2 files changed, 30 insertions(+)
>  create mode 100755 src/intel/genxml/gen_zipped_file.py
> 
> diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.genxml.am
> index 20e4b15786..1866d7e2df 100644
> --- a/src/intel/Makefile.genxml.am
> +++ b/src/intel/Makefile.genxml.am
> @@ -60,4 +60,5 @@ EXTRA_DIST += \
>         genxml/genX_pack.h \
>         genxml/gen_macros.h \
>         genxml/gen_pack_header.py \
> +       genxml/gen_zipped_file.py \
>         genxml/README
> diff --git a/src/intel/genxml/gen_zipped_file.py b/src/intel/genxml/gen_zipped_file.py
> new file mode 100755
> index 0000000000..a6e7b2717f
> --- /dev/null
> +++ b/src/intel/genxml/gen_zipped_file.py
> @@ -0,0 +1,29 @@
> +#!/usr/bin/env python2
> +#encoding=utf-8
> +#
> +# Copyright © 2017 Intel Corporation
> +#

Usually we also add the MIT text

> +
> +from __future__ import print_function
> +import os
> +import sys
> +import zlib
> +
> +def main():
> +    if len(sys.argv) < 2:
> +        print("No input xml file specified")
> +        sys.exit(1)
> +
> +    with open(sys.argv[1]) as f:
> +        compressed_data = zlib.compress(f.read())
> +
> +    gen_name = os.path.splitext(os.path.basename(sys.argv[1]))[0]
> +    print("static const uint8_t %s_xml[] = {" % gen_name)
> +    print("   ")

I think you want end='' on that last print

> +
> +    for i, c in enumerate(compressed_data, start=1):
> +        print("0x%.2x, " % ord(c), end='\n   ' if not i % 12 else '')
> +    print('\n};')
> +
> +if __name__ == '__main__':
> +    main()
> --
> 2.11.0

Other than that it looks good, with those changes:
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170310/637223cf/attachment.sig>