[Mesa-dev] [PATCH 7/7] util/disk_cache: hash pointer size into cache keys

[Timothy Arceri]

On 13/03/17 09:34, Grazvydas Ignotas wrote:
> On Mon, Mar 13, 2017 at 12:20 AM, Timothy Arceri <tarceri at itsqueeze.com> wrote:
>> We don't need to hash the pointer size. You can just remove
>> get_arch_bitness_str() and fix up the test. Timestamp should be enough on
>> its own, even if the 64/32bit builds have the same timestamp that is fine
>> because the cache entries are arch independent.
>
> Right now the entries are still pointer size dependent because the
> whole struct gl_shader_variable is written to cache, and that has a
> bunch of pointers. There might be other places like that, I haven't
> done a complete audit.
>

Hmm, yeah that's a pain. Would be hard to stop bugs slipping in if 
pointers are added elsewhere also ... I guess I'm ok with this then.