[Mesa-dev] [PATCH 1/2] configure.ac: require pthread-stubs only where available

[Emil Velikov]

On 10 March 2017 at 19:02, Randy Fishel <randy.fishel at oracle.com> wrote:
>
> On Fri, 10 Mar 2017, Emil Velikov wrote:
>
>> On 2 March 2017 at 19:02, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> > From: Emil Velikov <emil.velikov at collabora.com>
>> >
>> > The project is a thing only for BSD platforms. Or in other words - for
>> > any other platforms building/installing pthread-stubs results only in a
>> > pthread-stub.pc file.
>> >
>> > And even where it provides a DSO, there's a fundamental design issue
>> > with it - see the pthread-stubs mailing list for the specifics.
>> >
>> > Cc: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
>> > CC: Gary Wong <gtw at gnu.org>
>> > Cc: Randy Fishel <randy.fishel at oracle.com>
>> > Cc: Niveditha Rau <niveditha.rau at oracle.com>
>> > Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>> > ---
>> > Jeremy, others,
>> >
>> > Afaict pthread-stubs expands to a simple .pc on your platforms, but a
>> > confirmation will be greatly appreciated.
>> > ---
>> >  configure.ac | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/configure.ac b/configure.ac
>> > index a3d1a00bdd..e94e46a0b8 100644
>> > --- a/configure.ac
>> > +++ b/configure.ac
>> > @@ -799,7 +799,7 @@ fi
>> >
>> >  dnl pthread-stubs is mandatory on targets where it exists
>> >  case "$host_os" in
>> > -cygwin* )
>> > +linux* | cygwin* | darwin* | solaris* | gnu*)
>> >      pthread_stubs_possible="no"
>> >      ;;
>> >  * )
>> > --
>> Randy, Niveditha,
>>
>> Can you spare a minute to check if there is a pthread-stubs DSO
>> present on Solaris ?
>>
>> Thanks
>> Emil
>>
>
>   No, there is not.  pthreads is built into libc, and needs no extra
> configuration effort.  This *should* be the same for anything above
> S10 (including the OpenSolaris variants, though I don't have any
> immediate experience in that space; though there shouldn't be a reason
> to change it).
>
Perfect. Thanks for the confirmation Randy.

I've taken the liberty to consider the above as "acked-by" updated the
comment and pushed to master.

-Emil