[Mesa-dev] [PATCH] android: r600: fix libmesa_amd_common dependency

[Emil Velikov]

On 11 March 2017 at 16:26, Mauro Rossi <issor.oruam at gmail.com> wrote:
> 2017-03-08 17:44 GMT+01:00 Emil Velikov <emil.l.velikov at gmail.com>:
>>
>> On 5 March 2017 at 21:23, Mauro Rossi <issor.oruam at gmail.com> wrote:
>> > Adding libmesa_amd_common dependency and exporting its headers,
>> > avoids the following building error:
>> >
>> > external/mesa/src/gallium/drivers/r600/evergreen_compute.c:29:10: fatal
>> > error: 'ac_binary.h' file not found
>> >          ^
>> > 1 error generated.
>> >
>> > Fixes: 3bbbb63 "automake: r600: radeonsi: correctly manage
>> > libamd_common.la linking"
>> > Fixes: 503fb13 "radeon/ac: switch to ac_shader_binary_config_start()"
>>
>> Thank you Mauro.
>> I've applied a bit of polish and pushed to master.
>>
>> -Emil
>
>
> Hi Emil,
>
> With your v2 change I'm getting this building error, while it was building
> ok with the header export in libmesa_amd_common module.
>
Sounds like a bug elsewhere, since all the users of
inlibmesa_amd_common already explicitly have the include.

> [ 10% 389/3870] target  C: libmesa_pipe_r600_32 <=
> external/mesa/src/gallium/drivers/r600/evergreen_compute.c
> ...
> external/mesa/src/gallium/drivers/r600/evergreen_compute.c:29:10: fatal
> error: 'ac_binary.h' file not found
> #include "ac_binary.h"
>          ^
Can you enable verbose output [1] (?) to see the exact command line ?
There should be a -I..../src/amd/common in there.

-Emil
[1] http://elinux.org/Android_Build_System#Build_tricks