[Mesa-dev] [PATCH 1/2] drm.h: Include libdrm headers
Eric Engestrom
eric.engestrom at imgtec.com
Mon Mar 13 14:19:52 UTC 2017
On Monday, 2017-03-13 11:08:01 -0300, Fabio Estevam wrote:
> On Mon, Mar 13, 2017 at 11:07 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> > On Mon, Mar 13, 2017 at 10:04 AM, Fabio Estevam <festevam at gmail.com> wrote:
> >> Hi Ilia,
> >>
> >> On Mon, Mar 13, 2017 at 11:03 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> >>> Which repository do these patches apply to? Also the proper way of
> >>> including drm headers is
> >>
> >> These patches apply against kmscube repository:
> >> https://cgit.freedesktop.org/mesa/kmscube
> >
> > Ah, it'd probably be good to use a subject like
> >
> > [PATCH kmscube 1/2] drm.h: bla bla bla
>
> Yes, will do it for future patches. Thanks
Pro-tip: this will take care of this for you:
$ git config --local format.subjectPrefix "PATCH kmscube"
As for the patch itself, I'm confused. The error you're seeing is in
libdrm (so the fix should be there, not in each app that uses it),
however looking at xf86drm.h it already includes drm.h, and has since
forever (before v1.0.0).
Which version of libdrm are you using? Can you check in your
/home/buildroot/build/instance-0/output/host/usr/sparc64-buildroot-linux-gnu/sysroot/usr/include/xf86drm.h
around line 40, to see if it does indeed include drm.h?
Cheers,
Eric
More information about the mesa-dev
mailing list