[Mesa-dev] [PATCH 2/3] anv: Use vk_outarray in vkEnumeratePhysicalDevices

Chad Versace chadversary at chromium.org
Mon Mar 13 22:11:06 UTC 2017


On Mon 13 Mar 2017, Chad Versace wrote:
> On Mon 13 Mar 2017, Jason Ekstrand wrote:
> > On Mon, Mar 13, 2017 at 2:32 PM, Jason Ekstrand <jason at jlekstrand.net>
> > wrote:
> > 
> > > On Mon, Mar 13, 2017 at 2:23 PM, Chad Versace <chadversary at chromium.org>
> > > wrote:
> > >
> > >> No intended change in behavior. Just a refactor.
> > >> ---
> > >>  src/intel/vulkan/anv_device.c | 32 ++++++--------------------------
> > >>  1 file changed, 6 insertions(+), 26 deletions(-)
> > >>
> 
> 
> > >> +   if (vk_outarray_is_incomple(&out))
> > >> +      return VK_INCOMPLETE;
> > >>
> > >
> > > I still think I'd prefer a vk_outarray_status() helper and this would be
> > > "return vk_outarray_status(&out)".  But meh...
> 
> Ok. I'll change that to `return vk_outarray_status(&out)`.
> 
> > With or without that suggestion,
> > 
> > Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

Pushed.


More information about the mesa-dev mailing list