[Mesa-dev] [PATCH 0/6] isl: Fix requests for exact row pitch (v2)

Chad Versace chadversary at chromium.org
Mon Mar 13 22:27:57 UTC 2017


All callers of isl_surf_init() that set 'min_pitch' wanted to
request an *exact* row pitch, as evidenced by nearby asserts, but isl
lacked API for doing so. This series fixes that by adding a field,
isl_surf_init_info::row_pitch.

This prepares for VK_MESAX_external_image_dma_buf, which requires
support for create VkImages with an exact, user-provided row pitch.

This patch series lives at:
    git://git.kiwitree.net/~chadv/mesa
    refs/tags/chadv/review/isl-request-exact-row-pitch-v02
    gitweb: http://git.kiwitree.net/cgit/~chadv/mesa/tag/?h=chadv/review/isl-request-exact-row-pitch-v02

v2:
  - Validate the requested row pitch. This required more extensive
    refactors in patch 2.

Testing:
  I'm locally running dEQP-VK.
  I also pushed this to my 'jenkins' branch. But I no longer know to
  view the Jenkins results, because they're behind the Intel firewall.

Chad Versace (7):
  isl: Drop misplaced comment about padding
  isl: Refactor row pitch calculation (v2)
  isl: Add func isl_tiling_is_aux()
  isl: Validate the calculated row pitch
  isl: Let isl_surf_init's caller set the exact row pitch (v2)
  intel: Fix requests for exact surface row pitch
  isl: Drop unused isl_surf_init_info::min_pitch

 src/intel/blorp/blorp_blit.c |   3 +-
 src/intel/isl/isl.c          | 196 ++++++++++++++++++++++++++-----------------
 src/intel/isl/isl.h          |  16 +++-
 src/intel/vulkan/anv_blorp.c |   3 +-
 src/intel/vulkan/anv_image.c |   2 +-
 5 files changed, 134 insertions(+), 86 deletions(-)

-- 
2.12.0



More information about the mesa-dev mailing list