[Mesa-dev] [PATCH] android: i965: generate code for OA counter queries

Mauro Rossi issor.oruam at gmail.com
Mon Mar 13 22:36:47 UTC 2017


2017-03-13 14:00 GMT+01:00 Emil Velikov <emil.l.velikov at gmail.com>:

> On 12 March 2017 at 23:01, Mauro Rossi <issor.oruam at gmail.com> wrote:
> > Automake generation rules are replicated for android.
> > $* macro was expected to return "hsw" but instead gives "hsw.{h,c}"
> > so $(basename $*) is used as a workaround
> > to set the correct --chipset option for brw_oa.py script.
> >
> > Build tested with nougat-x86
> >
> > Fixes: e565505 "i965: Add script to gen code for OA counter queries"
>
> Let copy/pasta continue ... sigh, seems like people want to
> deliberatelly make their lives harder :-(
>

Hi Emil,

I don't see how just doing an include of Makefile.gen
<http://Makefile.gen.am> with current automake generation rules
would "cheat" Android Build System as we speak.

The generated files need to go in $OUT/gen/{STATIC,SHARED}_
LIBRARIES/[module_name]_intermediates
or Android Build System will just not care and throw a bunch of errors,
because it will check LOCAL_GENERATED_SOURCES list (with absolute path)
against the declared generation rules

In my understanding Makefile.gen as extrapolation of current am generation
rules,
will not suffice, would you please show a working PoC,
even for just one (medium/complex) prototype generation rule of your choice?

Thanks

Mauro
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170313/30b5d3e4/attachment-0001.html>


More information about the mesa-dev mailing list